Refactor routing primitive #9543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…anged test expectations Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
refactor-routing
branch
from
699367b to
bcf98c3
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
systay
reviewed
Jan 21, 2022
| ) | ||
|
|
||
| // Opcode is a number representing the opcode | ||
| // for any engine primitve. |
There was a problem hiding this comment.
nit: typo primitve, and it doesn't represent the opcode for any engine primitive, only the routing ones
There was a problem hiding this comment.
will fix the comment in follow up PR
GuptaManan100
approved these changes
Jan 21, 2022
Signed-off-by: Harshit Gangal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the route, update and delete engine primitive to use common routing logic. This makes it simpler to change the routing logic in one place now.
Related Issue(s)
Checklist
Deployment Notes